Don't mix if all non-private coins are unconfirmed. #12559
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sorry @MaxHillebrand NACK for having this v2.0.6. We've just fixed a huge bug caused by similarly innocent PR. |
|
I am still experiencing autocoinjoin starting while incoming funds are still unconfirmed (on master 0a439f2 / Win10) |
|
See #12602 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes an issue reported here: #12536 (comment) where if your wallet is fully private and then some coins are coming the CoinJoinManager will start coinjoin when it would be better to wait for confirmation
It is the way to fix it with the less probability of breaking things, but maybe it still breaks 1000 other things. IMO this issue is an important one because it is highly inefficient in a standard case.