Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor/contributing docs update #12583

Merged
merged 15 commits into from Mar 4, 2024
Merged

Refactor/contributing docs update #12583

merged 15 commits into from Mar 4, 2024

Conversation

kayevo
Copy link
Contributor

@kayevo kayevo commented Feb 29, 2024 •
edited

  • update VS Code auto clean code settings
  • add project's technologies and scope
  • add meetings platform and schedule information.

@kiminuo

@yahiheb yahiheb requested a review from kiminuo February 29, 2024 23:24
kiminuo
kiminuo reviewed Mar 1, 2024
View reviewed changes
CONTRIBUTING.md Outdated Show resolved Hide resolved
kiminuo
kiminuo reviewed Mar 1, 2024
View reviewed changes
CONTRIBUTING.md Outdated Show resolved Hide resolved
kiminuo
kiminuo reviewed Mar 1, 2024
View reviewed changes
CONTRIBUTING.md Outdated Show resolved Hide resolved
@kayevo kayevo changed the title Refactor/contributing docs update [Work in Progress] Refactor/contributing docs update Mar 1, 2024
@pull-request-size pull-request-size bot added size/S and removed size/XS labels Mar 1, 2024
@kayevo kayevo changed the title [Work in Progress] Refactor/contributing docs update Refactor/contributing docs update Mar 1, 2024
kiminuo
kiminuo reviewed Mar 2, 2024
View reviewed changes
CONTRIBUTING.md Outdated Show resolved Hide resolved
kiminuo
kiminuo reviewed Mar 2, 2024
View reviewed changes
CONTRIBUTING.md Outdated Show resolved Hide resolved
kiminuo
kiminuo reviewed Mar 2, 2024
View reviewed changes
CONTRIBUTING.md Outdated Show resolved Hide resolved
kiminuo
kiminuo reviewed Mar 2, 2024
View reviewed changes
CONTRIBUTING.md Outdated Show resolved Hide resolved
kiminuo
kiminuo reviewed Mar 2, 2024
View reviewed changes
CONTRIBUTING.md Outdated Show resolved Hide resolved
kayevo and others added 5 commits March 4, 2024 08:16
@kayevo @kiminuo
style: improve meeting schedule text
ff3be28 
Co-authored-by: Kimi <58662979+kiminuo@users.noreply.github.com>
@kayevo @kiminuo
refactor: remove extra comma
ef12815 
Co-authored-by: Kimi <58662979+kiminuo@users.noreply.github.com>
@kayevo @kiminuo
refactor: improve architecture description
a46abe5 
Co-authored-by: Kimi <58662979+kiminuo@users.noreply.github.com>
@kayevo @kiminuo
refactor: improve UI framework description
15fdc19 
Co-authored-by: Kimi <58662979+kiminuo@users.noreply.github.com>
@kayevo @kiminuo
refactor: improve dependencies description
7bb02e0 
Co-authored-by: Kimi <58662979+kiminuo@users.noreply.github.com>
@kayevo kayevo changed the title Refactor/contributing docs update [Work in progress]Refactor/contributing docs update Mar 4, 2024
@kayevo kayevo changed the title [Work in progress]Refactor/contributing docs update [Work in progress] Refactor/contributing docs update Mar 4, 2024
@kayevo kayevo changed the title [Work in progress] Refactor/contributing docs update Refactor/contributing docs update Mar 4, 2024
kiminuo
kiminuo reviewed Mar 4, 2024
View reviewed changes
CONTRIBUTING.md Outdated Show resolved Hide resolved
@kiminuo
Copy link
Collaborator

kiminuo commented Mar 4, 2024

One nit and otherwise LGTM.

MaxHillebrand
MaxHillebrand previously approved these changes Mar 4, 2024
View reviewed changes
Copy link
Member

@MaxHillebrand MaxHillebrand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, only downside is that we have to keep the date and time of the calls up to date here.

kiminuo
kiminuo reviewed Mar 4, 2024
View reviewed changes
CONTRIBUTING.md Outdated Show resolved Hide resolved
@kiminuo kiminuo merged commit 7c1292d into zkSNACKs:master Mar 4, 2024
3 of 6 checks passed
@kiminuo
Copy link
Collaborator

kiminuo commented Mar 4, 2024

Thanks for the cleanup!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kiminuo kiminuo kiminuo approved these changes

@MaxHillebrand MaxHillebrand MaxHillebrand left review comments

Assignees
No one assigned
Labels
size/S
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@kayevo @kiminuo @MaxHillebrand