Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix logging when we destroy a round (LoadBalancer) #12591

Merged

Conversation

adamPetho
Copy link
Collaborator

@adamPetho adamPetho commented Mar 1, 2024

Addresses: #12585 (comment)

Why is this so important for me?

Because in case there is an issue in the backend and we need to investigate it, more or less the logs are our only weapon.
If we cannot trust the logs or the logs are inaccurate, the investigation becomes much harder.

master produces logs like this:

2024-03-01 11:51:57.989 [71] INFO	Arena.CreateRoundsAsync (540)	Destroyed round with 360 inputs. Threshold: 450

This is NOT urgent to deploy.

Copy link
Collaborator

@molnard molnard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@turbolay
Copy link
Collaborator

turbolay commented Mar 1, 2024

Just a note, it is not detailed in OP's description, but this PR also fixes a potential problem where the roundDestroyerThreshold was based on Config and not roundParameters, so if for some reason a round had a different MinInput than what we had in the config, the roundDestroyerThreshold would've been non-sensical.

It didn't apply for the Delta PR specifically because RoundDestroyer doesn't apply for BlameRound

molnard
molnard previously approved these changes Mar 4, 2024
Copy link
Collaborator

@molnard molnard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK

@pull-request-size pull-request-size bot added size/S and removed size/XS labels Mar 4, 2024
@molnard molnard merged commit fbfe451 into zkSNACKs:master Mar 4, 2024
6 of 7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants