[VDG] Fix Amount Paste #12661
Merged
[VDG] Fix Amount Paste #12661
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
ichthus1604
commented
Mar 13, 2024
•
ichthus1604
commented
- Removes the restriction to paste amounts larger than current wallet balance
- Removes the automatic replacement that occurs when trying to paste amounts larger than total BTC in existence. This rule doesn't make sense for clipboard.
- Validations continue to work for both cases in the Send dialog: user won't be able to hit Continue button if input is invalid.
- Paste suggestions (flyout) keep their existing behavior: they will only appear if you have enough funds and there's a valid value to paste in the box.
- Pasting any kind of nonsense (non numeric characters, etc) is disallowed.
- Fixes [UI] Allow more than balance amount paste #12645
|
@ichthus1604 Please fix the tests too |
soosr
reviewed
Mar 13, 2024
|
After #12660 is merged, I need to fix this: #12660 (comment) in this PR. Since this PR touches flyout related code, it will be less problematic to include this fix in here rather than in the other PR. |
Merged. |
Done ;) |
soosr
requested changes
Mar 14, 2024
soosr
approved these changes
Mar 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.