Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Organize (move) client side CJ related code #12671

Merged
merged 5 commits into from Mar 15, 2024
Merged

Conversation

molnard
Copy link
Collaborator

@molnard molnard commented Mar 14, 2024

First step of #12615


public class DependencyGraphTaskScheduler
{
public DependencyGraphTaskScheduler(DependencyGraph graph)
{
Graph = graph;
var allInEdges = Enum.GetValues<CredentialType>()
.SelectMany(type => Enumerable.Concat<RequestNode>(Graph.Reissuances, Graph.Outputs)
.SelectMany(type => Graph.Reissuances.Concat<RequestNode>(Graph.Outputs)
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was done automatically.

@@ -37,7 +37,7 @@ private static IEnumerable<(long Sum, int Count, ulong Decomposition)> InternalC
long sum,
int k)
{
accumulator = (accumulator << 8) | ((ulong)currentDenominationIdx & 0xff);
accumulator = accumulator << 8 | (ulong)currentDenominationIdx & 0xff;
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was done automatically.

@molnard molnard requested a review from yahiheb March 14, 2024 13:40
@molnard molnard marked this pull request as ready for review March 14, 2024 14:01
Copy link
Collaborator

@yahiheb yahiheb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested coinjoin, everything looked good.

WabiSabi/Client/CoinJoin/Client this name can be confusing because there is already another folder with the same name.

I would rename the folder Decomp to Decomposer or Decomposition

@molnard
Copy link
Collaborator Author

molnard commented Mar 15, 2024

WabiSabi/Client/CoinJoin/Client this name can be confusing because there is already another folder with the same name.

I have no better idea that can cause less confusion.

@molnard
Copy link
Collaborator Author

molnard commented Mar 15, 2024

@yahiheb do you know since when the parenthesis are removed automatically?

Hmm, it is not removed if I just add it back and Save. I don't understand what is happening here.

@molnard
Copy link
Collaborator Author

molnard commented Mar 15, 2024

I won't fix the last CF issues because that would be a refactoring. I just want to move files here.

@yahiheb
Copy link
Collaborator

yahiheb commented Mar 15, 2024

@yahiheb do you know since when the parenthesis are removed automatically?

Idk, they are not removed automatically for me using VS.

@molnard molnard merged commit 0494c26 into zkSNACKs:master Mar 15, 2024
7 of 8 checks passed
@@ -2,7 +2,7 @@
using System.Diagnostics.CodeAnalysis;
using WalletWasabi.Extensions;

namespace WalletWasabi.WabiSabi.Client;
namespace WalletWasabi.WabiSabi.Client.CoinJoin.Client.Decomp;
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My bad why this was not changed...

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nevermind GitHub displayed it wrong.

@molnard molnard deleted the movecj branch March 15, 2024 16:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants