New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Organize (move) client side CJ related code #12671
Conversation
|
||
public class DependencyGraphTaskScheduler | ||
{ | ||
public DependencyGraphTaskScheduler(DependencyGraph graph) | ||
{ | ||
Graph = graph; | ||
var allInEdges = Enum.GetValues<CredentialType>() | ||
.SelectMany(type => Enumerable.Concat<RequestNode>(Graph.Reissuances, Graph.Outputs) | ||
.SelectMany(type => Graph.Reissuances.Concat<RequestNode>(Graph.Outputs) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This was done automatically.
@@ -37,7 +37,7 @@ private static IEnumerable<(long Sum, int Count, ulong Decomposition)> InternalC | |||
long sum, | |||
int k) | |||
{ | |||
accumulator = (accumulator << 8) | ((ulong)currentDenominationIdx & 0xff); | |||
accumulator = accumulator << 8 | (ulong)currentDenominationIdx & 0xff; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This was done automatically.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested coinjoin, everything looked good.
WabiSabi/Client/CoinJoin/Client
this name can be confusing because there is already another folder with the same name.
I would rename the folder Decomp
to Decomposer
or Decomposition
I have no better idea that can cause less confusion. |
@yahiheb do you know since when the parenthesis are removed automatically? Hmm, it is not removed if I just add it back and Save. I don't understand what is happening here. |
I won't fix the last CF issues because that would be a refactoring. I just want to move files here. |
Idk, they are not removed automatically for me using VS. |
@@ -2,7 +2,7 @@ | |||
using System.Diagnostics.CodeAnalysis; | |||
using WalletWasabi.Extensions; | |||
|
|||
namespace WalletWasabi.WabiSabi.Client; | |||
namespace WalletWasabi.WabiSabi.Client.CoinJoin.Client.Decomp; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
My bad why this was not changed...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nevermind GitHub displayed it wrong.
First step of #12615