Trezor Safe 3 implementation #12687
Trezor Safe 3 implementation #12687
Conversation
|
Add reviewers if you need review. LGTM please fix the conflict and we can merge. |
There was a problem hiding this comment.
don't forget to also add it to the supported hww doc
https://github.com/zkSNACKs/WalletWasabi/blob/master/WalletWasabi.Documentation/WasabiCompatibility.md#officially-supported-hardware-wallets
yes, you are absolutely right, I will correct it |
| @@ -62,10 +62,12 @@ public bool IsOfflinePsbtWorkflowCompatible() | |||
| HardwareWalletModels.Coldcard => true, | |||
| HardwareWalletModels.Ledger_Nano_S or HardwareWalletModels.Ledger_Nano_X or HardwareWalletModels.Ledger_Nano_S_Plus => false, | |||
| HardwareWalletModels.Trezor_1 => false, | |||
| HardwareWalletModels.Trezor_T => true, | |||
| HardwareWalletModels.Trezor_T => false, | |||
There was a problem hiding this comment.
Was this value wrong and it got corrected?
Do we still need IsOfflinePsbtWorkflowCompatible?
There was a problem hiding this comment.
The first time when I read the Trezor T specs, I thought it could support native PSBT workflow
Yes, I need it in upcoming features
|
Should we also add |
Yes, but it would be in another PR |
Why not in this PR, it is a small change. |
Okay, I put in there the validation, but what you made PR, please remove it, I need to recheck it with real data that comes from the device. I can only do this if I go through the validation from each device. |
Fixes: #12143
Introduction
The HWI already supports the Trezor Safe 3 hardware wallet, but until now, Wasabi wallet did not. Therefore, we decided to implement this in the current codebase.
Solution
We acquired a Trezor Safe 3 hardware wallet and initialized it with the appropriate parameters. After this, I implemented the new Enums, HardwareWalletModel and WalletType, in the code.
I started the Wasabi wallet and was able to add it as a wallet.
Subtasks
Tests on Main net
Tested operating systems