Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UpdateChecker: Increase interval to 1 hour #12716

Merged

Conversation

kiminuo
Copy link
Collaborator

@kiminuo kiminuo commented Mar 25, 2024

I don't think this behavior is OK even temporarily.

@molnard
Copy link
Collaborator

molnard commented Mar 25, 2024

Will the client detect the update right after the connection is available with the backend?

Copy link
Collaborator

@turbolay turbolay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK even if the WebSocket's PR can make this one useless

Will the client detect the update right after the connection is available with the backend?

Yes. For some reason even twice:

CleanShot 2024-03-25 at 17 56 07@2x

Copy link
Member

@MaxHillebrand MaxHillebrand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

1 hour is better than 5 seconds.

@MarnixCroes
Copy link
Collaborator

cACK 5s is obviously overkill
any privacy downsides here?
that the same client will check exactly every 1h (not with a unique identity each time, if I'm correct)?

@adamPetho
Copy link
Collaborator

any privacy downsides here?
that the same client will check exactly every 1h (not with a unique identity each time, if I'm correct)?

If 5s request period was acceptable, then I don't think there is a privacy risk for increasing this.

@adamPetho adamPetho merged commit ac2f064 into zkSNACKs:master Mar 26, 2024
8 checks passed
@kiminuo kiminuo deleted the feature/2024-03-25-UpdateChecker-frequency branch March 26, 2024 12:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants