Make UpdateManager a PeriodicRunner

[turbolay]

Period = 1 day according to #13027 (comment)

[Szpoti]

utACK.

Do you think it makes sense to register UpdateManager as a Hosted Service now it's a periodic runner?

[turbolay]

Do you think it makes sense to register UpdateManager as a Hosted Service now it's a periodic runner?

I thought about it while making this PR but I don't think so. If we need it somewhere or to stop it or whatever in the future well we can register it. If someone thinks differently, I will update this PR.

[molnard]

LGTM. It makes sense to have this because some users are just running the software without restart. They might not even look at the screen but if they do at least they will see the update message.

Regarding the disposal... UpdateManager is IDisposable - so you need to do that somewhere. Right now it is missing.

There are two options:

• Add it to HostedServices.
• Add the disposal to Global.DisposeAsync.

[turbolay]

@lontivero I can see you forced push here, what happened to this PR?

[kiminuo]

Code looks good to me but this line fails for me:

https://github.com/zkSNACKs/WalletWasabi/blob/97032bc4711bddd2eddf81c9633216767d0cc35c/WalletWasabi/WebClients/Wasabi/WasabiClient.cs#L173

and I get always "Not Found":

2024-05-27 10:20:47.581 [ 14] ERROR Getting new update failed with error. Exception: System.Net.Http.HttpRequestException: Not Found
   at WalletWasabi.Tor.Http.Extensions.HttpResponseMessageExtensions.ThrowRequestExceptionFromContentAsync(HttpResponseMessage me, CancellationToken cancellationToken) in D:\work\WasabiWallet\WalletWasabi.review\WalletWasabi\Tor\Http\Extensions\HttpResponseMessageExtensions.cs:line 120
   at WalletWasabi.WebClients.Wasabi.WasabiClient.GetBackendMajorVersionAsync(CancellationToken cancel) in D:\work\WasabiWallet\WalletWasabi.review\WalletWasabi\WebClients\Wasabi\WasabiClient.cs:line 177
   at WalletWasabi.WebClients.Wasabi.WasabiClient.CheckUpdatesAsync(CancellationToken cancel) in D:\work\WasabiWallet\WalletWasabi.review\WalletWasabi\WebClients\Wasabi\WasabiClient.cs:line 188
   at WalletWasabi.Services.UpdateManager.ActionAsync(CancellationToken cancellationToken) in D:\work\WasabiWallet\WalletWasabi.review\WalletWasabi\Services\UpdateManager.cs:line 53

This makes me think that the endpoint got changed by a Lucas PR (there was a PR changing API endpoints). But I don't know for sure.

[turbolay]

@kiminuo The endpoint was changed on this branch, and it's not deployed yet, which explains why it doesn't reach. I would like to merge this PR so I can make a new PR to merge to master. I will take care to change the endpoint back to Software.

[molnard]

Cannot test it, becasue the endpoint is missing. But the code LGTM.