Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to Bitcoin 18 #1403

Merged
merged 2 commits into from May 4, 2019

Conversation

Projects
None yet
2 participants
@nopara73
Copy link
Collaborator

commented May 3, 2019

Bitcoin Core 18 is out: https://bitcoincore.org/en/releases/0.18.0/

The first blocker issue I encountered is that they removed the generate RPC (there may be more.) bitcoin/bitcoin#15492

generate is deprecated and will be fully removed in a subsequent major version. This RPC is only used for testing, but its implementation reached across multiple subsystems (wallet and mining), so it is being deprecated to simplify the wallet-node interface. Projects that are using generate for testing purposes should transition to using the generatetoaddress RPC, which does not require or use the wallet component. Calling generatetoaddress with an address returned by the getnewaddress RPC gives the same functionality as the old generate RPC. To continue using generate in this version, restart bitcoind with the -deprecatedrpc=generate configuration option.

We need to add to NBitcoin and make the Generate and GenerateAsync do getnewaddress before generatetoaddress so we can keep compatibility.

@lontivero

This comment has been minimized.

Copy link
Contributor

commented May 3, 2019

@nopara73 nopara73 marked this pull request as ready for review May 4, 2019

@nopara73

This comment has been minimized.

Copy link
Collaborator Author

commented May 4, 2019

Thanks @lontivero! This seemed to was the only blocker.

@nopara73 nopara73 merged commit d518562 into zkSNACKs:master May 4, 2019

4 checks passed

CodeFactor No issues found.
Details
Wasabi.Linux #20190504.2 succeeded
Details
Wasabi.Osx #20190504.2 succeeded
Details
Wasabi.Windows #20190504.2 succeeded
Details

@nopara73 nopara73 deleted the nopara73:bitcoin18 branch May 4, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.