Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Display 'Label required' for more time #1510

Merged

Conversation

Projects
None yet
3 participants
@lontivero
Copy link
Collaborator

commented May 29, 2019

Close #1480

@lontivero

This comment has been minimized.

Copy link
Collaborator Author

commented May 29, 2019

@molnard could you take a look at the CI, please? It fails because the mutex is not released I think. That has nothing to do with this PR because the change that I did is trivial.

Starting test execution, please wait...
2019-05-29 20:39:38 ERROR AsyncMutex: InvalidOperationException: Previous AsyncLock state was unexpected: prev:StatusReleasing now:StatusAcquiring. in file-5BD1C5B
2019-05-29 20:39:38 ERROR AsyncMutex: InvalidOperationException: Thread should not be alive. in file-5BD1C5B
2019-05-29 20:39:38 WARNING AsyncMutex: System.InvalidOperationException: Previous AsyncLock state was unexpected: prev:StatusAcquiring now:StatusReady.
   at Nito.AsyncEx.AsyncMutex.ChangeStatus(AsyncLockStatus newStatus, AsyncLockStatus[] expectedPreviousStatuses) in /home/vsts/work/1/s/WalletWasabi/Nito/AsyncEx/AsyncMutex.cs:line 261
   at Nito.AsyncEx.AsyncMutex.ChangeStatus(AsyncLockStatus newStatus, AsyncLockStatus expectedPreviousStatus) in /home/vsts/work/1/s/WalletWasabi/Nito/AsyncEx/AsyncMutex.cs:line 250
   at Nito.AsyncEx.AsyncMutex.ReleaseLock() in /home/vsts/work/1/s/WalletWasabi/Nito/AsyncEx/AsyncMutex.cs:line 388
   at Nito.AsyncEx.AsyncMutex.Key.Dispose(Boolean disposing) in /home/vsts/work/1/s/WalletWasabi/Nito/AsyncEx/AsyncMutex.cs:line 451
@molnard

This comment has been minimized.

Copy link
Collaborator

commented May 30, 2019

Strange. Could you merge the master and try it again?

@lontivero

This comment has been minimized.

Copy link
Collaborator Author

commented May 30, 2019

Now it fails in Linux because it doesn't find a path (?)

@nopara73

This comment has been minimized.

Copy link
Collaborator

commented May 31, 2019

The issue experienced is unrelated to this PR though so I merge it.

@nopara73 nopara73 merged commit 7771375 into zkSNACKs:master May 31, 2019

3 of 4 checks passed

Wasabi.Linux #20190530.11 failed
Details
CodeFactor No issues found.
Details
Wasabi.Osx #20190530.11 succeeded
Details
Wasabi.Windows #20190530.10 succeeded
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.