Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Status Page Integration: Included all bits for suggested Status Page, fixes #1559 #1654

Closed
wants to merge 4 commits into from

Conversation

xavierfiechter
Copy link
Contributor

Link added to help menu and to the about panel. The link points to https://status.wasabiwallet.io/ .
Of course this site can’t be reached currently. StatusPage.io allows custom DNS, see issue for details.

xavierfiechter and others added 3 commits June 28, 2019 22:30
Link added to help menu and to the about panel. The link points to https://status.wasabiwallet.io/ .
Of course this site can’t be reached currently. StatusPage.io allows custom DNS, see issue for details.
…ll-bits-for-suggested-status-page-fixes-1559
{
try
{
IoHelpers.OpenBrowser("https://status.wasabiwallet.io/");
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am not sure about this because Wasabi servers should only be accessed through Tor. This could introduce suspicions about Wasabi logging IP addresses.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's a good point.

In #1559 (comment) uptime robot was suggested, which is a wildly used, generic service. This whould not harm the privacy.

Further, the link is only loaded on demand (not in the background, polled, etc.).

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Use this link. I finalized the status site:
https://stats.uptimerobot.com/W7q65in4y

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@molnard @nopara73 the PR is updated and the test passed. It's ready to merge.


[ExportMainMenuItem("Help", "Customer Support")]
[DefaultOrder(3)]
[DefaultGroup("Support")]
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why is it renamed?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's not renamed, it's a new entry above the "Customer Support". See https://github.com/zkSNACKs/WalletWasabi/blob/d8bb82e7c4e8cda3ffb935f131b894369685be9d/WalletWasabi.Gui/Shell/MainMenu/HelpMainMenuItems.cs

Often a Status Page removes the load on the Customer Support, that's why the Status Page should be listet before customer support IMHO.

@@ -20,6 +20,10 @@
<TextBlock Text="Source Code: " />
<controls:ExtendedTextBox Text="https://github.com/zkSNACKs/WalletWasabi/" Classes="selectableTextBlock hyperLink" />
</StackPanel>
<StackPanel Orientation="Horizontal">
<TextBlock Text="Status Page: " />
<controls:ExtendedTextBox Text="https://status.wasabiwallet.io/" Classes="selectableTextBlock hyperLink" />
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same comment about reaching Wasabi servers without Tor.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See above...

@molnard
Copy link
Contributor

molnard commented Jul 16, 2019

I changed the Icon and removed some unnecessary code:
xavierfiechter#2

@xavierfiechter
Copy link
Contributor Author

@Mixelated merged

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants