Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change wording of autocopy setting to be more accurate #2022

Merged
merged 3 commits into from Jul 27, 2019
Merged

Change wording of autocopy setting to be more accurate #2022

merged 3 commits into from Jul 27, 2019

Conversation

benthecarman
Copy link
Contributor

No description provided.

molnard
molnard requested changes Jul 26, 2019
View reviewed changes
WalletWasabi.Gui/Tabs/SettingsView.xaml Outdated Show resolved Hide resolved
MaxHillebrand
MaxHillebrand approved these changes Jul 26, 2019
View reviewed changes
WalletWasabi.Gui/Tabs/SettingsView.xaml Outdated Show resolved Hide resolved
@Rmartin1104
Copy link
Collaborator

Rmartin1104 commented Jul 26, 2019 •
edited

Result Status Note
Wasabi GUI exit test Pass Good
Filter downloading tests Pass Good
Context menu and selection tests Pass Good

win 10

@benthecarman
Copy link
Contributor Author

Changed wording, added a small grammatical error fix for LWM

nopara73
nopara73 suggested changes Jul 27, 2019
View reviewed changes
Copy link
Contributor

@nopara73 nopara73 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The settings tab doesn't scale for such long messages.
image

@nopara73 nopara73 merged commit 64c1675 into zkSNACKs:master Jul 27, 2019
@benthecarman benthecarman deleted the autocopy_working branch July 28, 2019 05:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nopara73 nopara73 nopara73 requested changes

@molnard molnard molnard requested changes

@MaxHillebrand MaxHillebrand MaxHillebrand approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@benthecarman @Rmartin1104 @nopara73 @molnard @MaxHillebrand