Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix name violation #2154

Merged
merged 4 commits into from Aug 29, 2019
Merged

Fix name violation #2154

merged 4 commits into from Aug 29, 2019

Conversation

yahiheb
Copy link
Collaborator

@yahiheb yahiheb commented Aug 23, 2019

No description provided.

benthecarman
benthecarman previously approved these changes Aug 23, 2019
View reviewed changes
nopara73
nopara73 suggested changes Aug 23, 2019
View reviewed changes
Copy link
Contributor

@nopara73 nopara73 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could be a getter, too, no? @jmacato ?

@nopara73 nopara73 requested a review from jmacato August 27, 2019 09:04
jmacato
jmacato previously approved these changes Aug 27, 2019
View reviewed changes
Copy link
Contributor

@jmacato jmacato left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@nopara73 I think it's alright for the Extensions field to be the way it is now since it's only set once

@jmacato
Copy link
Contributor

jmacato commented Aug 28, 2019

@nopara73 Yes i think that works too, also removing the ToArray() call on the assignment to make it all line up.

@lontivero lontivero merged commit af6ef2b into zkSNACKs:master Aug 29, 2019
@yahiheb yahiheb deleted the name-violation branch August 29, 2019 19:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lontivero lontivero lontivero approved these changes

@nopara73 nopara73 nopara73 approved these changes

@benthecarman benthecarman benthecarman left review comments

@jmacato jmacato jmacato left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@yahiheb @jmacato @lontivero @nopara73 @benthecarman