Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix name violation #2154

Merged
merged 4 commits into from Aug 29, 2019

Conversation

@yahiheb
Copy link
Collaborator

commented Aug 23, 2019

No description provided.

@nopara73
Copy link
Collaborator

left a comment

Could be a getter, too, no? @jmacato ?

@nopara73 nopara73 requested a review from jmacato Aug 27, 2019

@jmacato
Copy link
Collaborator

left a comment

@nopara73 I think it's alright for the Extensions field to be the way it is now since it's only set once

@jmacato

This comment has been minimized.

Copy link
Collaborator

commented Aug 28, 2019

@nopara73 Yes i think that works too, also removing the ToArray() call on the assignment to make it all line up.

@lontivero lontivero merged commit af6ef2b into zkSNACKs:master Aug 29, 2019

4 checks passed

CodeFactor No issues found.
Details
Wasabi.Linux #20190828.4 succeeded
Details
Wasabi.Osx #20190828.5 succeeded
Details
Wasabi.Windows #20190828.4 succeeded
Details

@yahiheb yahiheb deleted the yahiheb:name-violation branch Aug 29, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants
You can’t perform that action at this time.