Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix NREs #2814

Merged
merged 2 commits into from Dec 9, 2019
Merged

Fix NREs #2814

merged 2 commits into from Dec 9, 2019

Conversation

nopara73
Copy link
Contributor

@nopara73 nopara73 commented Dec 9, 2019 •
edited

Closes #2800
Closes #2799

@nopara73 nopara73 merged commit 8819161 into zkSNACKs:master Dec 9, 2019
@nopara73 nopara73 deleted the context branch December 9, 2019 11:45
@yahiheb
Copy link
Collaborator

yahiheb commented Dec 9, 2019

When you right click in an empty coinlist or when no row is selected you still get the greyed out menu, shouldn't not display it when it is not needed?

@nopara73
Copy link
Contributor Author

nopara73 commented Dec 9, 2019

IMO it's good both ways, but @molnard did it: #2816

@molnard molnard mentioned this pull request Dec 13, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@nopara73 @yahiheb