Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tweak LegalDocsView. #3537

Merged
merged 5 commits into from
May 7, 2020
Merged

Tweak LegalDocsView. #3537

merged 5 commits into from
May 7, 2020

Conversation

jmacato
Copy link
Contributor

@jmacato jmacato commented Apr 15, 2020

Trying to get some work done while recovering :)

Should fix #3478 though I'm not considering the green button design change until we have some further discussions for changing the overall look of our buttons app-wide.

cc: @UkolovaOlga @molnard

Copy link
Contributor

@MaxHillebrand MaxHillebrand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tested on Qubes 4 Debian 10

The button is now at the bottom.
However, I would prefer if the size of the button is only the size of Agree, and not all the width of the GUI.

screenshot_20200415_092134

@molnard
Copy link
Contributor

molnard commented Apr 15, 2020

You do not prefer big buttoned forms?

@molnard
Copy link
Contributor

molnard commented Apr 15, 2020

A loved the border, now it looks like a big text bucket. The new position of the button is OK but I would reduce the size of it and put something green there. A checkmark or a green border.

@jmacato
Copy link
Contributor Author

jmacato commented Apr 24, 2020

image

I wonder if this is okay

MaxHillebrand
MaxHillebrand previously approved these changes Apr 24, 2020
Copy link
Contributor

@MaxHillebrand MaxHillebrand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Might be a bit "too much" green, but still, I like it - ACK

@molnard
Copy link
Contributor

molnard commented Apr 29, 2020

I like it. Can you make the button fixed size?

@jmacato
Copy link
Contributor Author

jmacato commented Apr 29, 2020

@molnard Done :) Please re-check

Copy link
Contributor

@MaxHillebrand MaxHillebrand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tACK

Copy link
Collaborator

@yahiheb yahiheb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and it looks better, maybe the color is too green.

@danwalmsley danwalmsley merged commit 21707d5 into WalletWasabi:master May 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Terms & Conditions popup UI improvements v.1.1.11
5 participants