-
Notifications
You must be signed in to change notification settings - Fork 495
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Prototype/Do-not-Merge] Add NonWitness UTXO in PSBT #3793
[Prototype/Do-not-Merge] Add NonWitness UTXO in PSBT #3793
Conversation
This is the psbt when building a transaction
|
there is this error when signing:
|
The test was done using the HWI that comes within Wasabi |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Concept ACK. What BitcoinStore do if the tx is not there?
@molnard it returns false, which skips the input's non segwit field. We can do a warning of some kind if it does that |
If the transaction is not in the |
…e latest NBitcoin with fixes
b264751
to
b44cb53
Compare
So we should not support PayJoin with Hardware wallets? |
@jmacato please make this PR reviewable.
IMO all these should be done in separate PRs because we need them independently of this specific PR. |
@lontivero yes but to reiterate again: this PR is only for prototyping and i don't recommend reviewing this. I'll be posting series of PR's for this issue tomorrow. |
Trezor requires the inclusion of the transactions that create each coin that is being spent and in payjoin we don't have the transaction for the coin added by the receiver so, given we don't have the required info Trezor will refuse to sign that payjoin transaction. Note: the receiver could include that transaction in the psbt that he responds with but that requires a change in the bip78 (that bip is being discussed right now so, we could suggest this) |
also i didnt made any macOS build of HWI since docker doesnt support them (and i dont have mac too...) we need to have a new release from HWI |
I see. What are we going to do with these binaries? I think we have to wait for the official release. @achow101, what is the plan? are you going to release a new version of HWI containing the change for Trezor only or that is just one of many other changes that will be included in a much bigger release version? |
There is a release candidate bitcoin-core/HWI#340 (comment) |
#3822 is merged so closing this. |
DO NOT MERGE since this is only to verify if the solution works
This is a prototype for resolving the Trezor hardware wallet issue.
Depends on MetacoSA/NBitcoin#873Depends on bitcoin-core/HWI#340
Contributes to #3734