Allow suggesting same words multiple times when typing recovery words #4106
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MaxHillebrand
approved these changes
Aug 4, 2020
|
LGTM. |
lontivero
approved these changes
Aug 6, 2020
There was a problem hiding this comment.
This PR assumes it is good to suggest already-used words because the mnemonic can contain duplicated words.
The previous implementation assumes that, given randomly generated mnemonics do not contain duplicated words in most of the cases, then it makes no sense to suggest already-used words.
IMO both are okay, it is just a matter of assumptions.
|
@molnard Should we backport this one? |
|
No this is a nuance. Go for 2.0. |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4105