Receive change in the first clean change address #4207
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I don't think it should be backported. I don't remember what was it exactly, but we relied on this behavior (and probably rely on it today with the backport?) as commented here: #4172 (comment) |
|
But this might be the source of the wrong balance at recovery issue #3552 |
|
Sure, but it also could be the source of something worse. But your call. |
molnard
added a commit
to molnard/WalletWasabi
that referenced
this pull request
Oct 25, 2021
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4172
Currently when you make a transaction that generates change, the change goes to a random address from the list of clean change addresses. The standard behavior is to receive the change in the first clean change address.
Used
FirstOrDefault()becauseRandomElement()returnsdefaultif there is no element. https://github.com/zkSNACKs/WalletWasabi/blob/master/WalletWasabi/Extensions/LinqExtensions.cs#L44-L61