Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add TorInstallator class. #4354

Merged
merged 1 commit into from Sep 11, 2020
Merged

Add TorInstallator class. #4354

merged 1 commit into from Sep 11, 2020

Conversation

kiminuo
Copy link
Collaborator

@kiminuo kiminuo commented Sep 11, 2020

This PR is "move-only" PR that adds new TorInstallator class.

The future plans are:

  • Research whether we can test Tor installation.
  • Verify that the installation is actually correct - Tor program is where it is supposed to be.
  • Probably attempt to handle exceptions from IoHelpers.BetterExtractZipToDirectoryAsync in InstallAsync right away to return nice report what actually failed.

@kiminuo kiminuo force-pushed the feature/2020-09-11-Add-TorInstallator branch from db750af to fc9218f Compare September 11, 2020 09:09
@nopara73
Copy link
Contributor

This is very good.

@nopara73 nopara73 merged commit 6441230 into zkSNACKs:master Sep 11, 2020
@kiminuo kiminuo deleted the feature/2020-09-11-Add-TorInstallator branch September 11, 2020 09:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@molnard molnard Awaiting requested review from molnard

Assignees
No one assigned
Labels
size/M
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@kiminuo @nopara73