Send Wasabi to Tray on Closing

[molnard]

Closes: #4790, #4798
Related: #4591

[adamPetho]

tACK on Win10, macOS Big Sufur 11.5.2 and Ubuntu 20.04 🎉

[MaxHillebrand]

tested 26fe35b on Qubes 4 Debian 11 with i3wm

when pressing Power+shift+q [i3wm shortcut for window close], I get this debug, and GUI keeps running.
[1] DEBUG HideShowBehavior:OnAttached (52) Closing event, cancellation of the close is set to: 'False'.

if I press Ctrl+c in the terminal that runs dotnet, then Wasabi shutsdown gracefully.

---

So far, shutting down GUI & keeping running in background does not work for i3wm.
[i know, not supported, not needed, just fyi.]

[adamPetho]

when pressing Power+shift+q [i3wm shortcut for window close], I get this debug, and GUI keeps running.

Yep, we are aware of that issue. It's reproducible on master too. Only in Debug mode tho.

[yahiheb]

tACK on Win10

[MaxHillebrand]

fust fyi, this does work in i3wm in general. For example, with slack or telegram. Power+Shift+q shuts down the GUI, but the tray icon persists. When clicking on the tray icon, a new window pops up super quickly.

It would be pretty cool to get that in Wasabi too actually. 🖤

[Szpoti]

tACK on Win10 and Ubuntu 18.04.
Just an intersting NIT on Win10, if I open up the tray menu, right-click on Wasabi, then click out to the desktop, only Wasabi's menu gets hidden, the tray menu stays open for a short time

[molnard]

[1] DEBUG HideShowBehavior:OnAttached (52) Closing event, cancellation of the close is set to: 'False'.

@MaxHillebrand That means there was no cancellation on the quit procedure - so basically the logic there let the software quit, it is not prevented - so my conclusion is that this is not related to this PR.

Can you check it on master? It is important to separate otherwise this PR tries to solve more problem that it should.

[yahiheb]

tACK

[yahiheb]

Should the default behavior be True? That is not the expected behavior so IMO maybe not.

[molnard]

Most of the software behaves like that. @danwalmsley what do you think? Should we Hide on close by default? Keep in mind that we are aiming at users who will never change the settings.

[yahiheb]

Other than this #6518 (comment), tACK

[nopara73]

cACK for default, very good.

[danwalmsley]

@molnard as discussed on Slack... my view is that when the user closes the window it absolutely should move to taskbar by default, and that this behavior is actually fundamental to the new WabiSabi and auto coinjoin feature. Users expect certain types of apps to stay running in the background, i.e. Slack, Telegram, many crypto wallets also, its normal and understood behavior.

We can use the technique where the first time someone does it, you popup a notice something like.

"Hey, im still running in the background!"

but IMO users will just understand it.

[adamPetho]

The ShowCommand fires twice, but it can be fixed easily in another PR and it doesn't mess up anything, so tACK.