Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[VDG] [Trivial] Fix music box TimeSpan format #7447

Merged
merged 2 commits into from
Mar 4, 2022
Merged

[VDG] [Trivial] Fix music box TimeSpan format #7447

merged 2 commits into from
Mar 4, 2022

Conversation

SuperJMN
Copy link
Contributor

@SuperJMN SuperJMN commented Mar 3, 2022

Fixes this problem:
image

@SuperJMN SuperJMN changed the title Fix music box TimeSpan format [VDG] Fix music box TimeSpan format Mar 3, 2022
@SuperJMN SuperJMN changed the title [VDG] Fix music box TimeSpan format [VDG] Trivial Fix music box TimeSpan format Mar 3, 2022
@SuperJMN SuperJMN changed the title [VDG] Trivial Fix music box TimeSpan format [VDG] Trivial: Fix music box TimeSpan format Mar 3, 2022
jmacato
jmacato reviewed Mar 3, 2022
View reviewed changes
Copy link
Contributor

@jmacato jmacato left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a suggestion :)

WalletWasabi.Fluent/ViewModels/Wallets/CoinJoinStateViewModel.cs Show resolved Hide resolved
@pull-request-size pull-request-size bot added size/S and removed size/XS labels Mar 3, 2022
yahiheb
yahiheb approved these changes Mar 3, 2022
View reviewed changes
Copy link
Collaborator

@yahiheb yahiheb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I pushed bf97df3 to fix the PR

tACK

@SuperJMN
Copy link
Contributor Author

SuperJMN commented Mar 3, 2022

I pushed bf97df3 to fix the PR

tACK

@jmacato @yahiheb
Thanks! It seems I forgot to add the format to the other ToString() 🤦‍♂️

@SuperJMN SuperJMN removed the request for review from soosr March 4, 2022 06:52
MaxHillebrand
MaxHillebrand approved these changes Mar 4, 2022
View reviewed changes
Copy link
Contributor

@MaxHillebrand MaxHillebrand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tACK bf97df3

@danwalmsley danwalmsley merged commit c257d88 into WalletWasabi:master Mar 4, 2022
@SuperJMN SuperJMN deleted the fix-musicbox-timespan-format branch March 7, 2022 08:42
@SuperJMN SuperJMN changed the title [VDG] Trivial: Fix music box TimeSpan format [VDG] [Trivial] Fix music box TimeSpan format Mar 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jmacato jmacato jmacato left review comments

@danwalmsley danwalmsley danwalmsley approved these changes

@MaxHillebrand MaxHillebrand MaxHillebrand approved these changes

@yahiheb yahiheb yahiheb approved these changes

Assignees
No one assigned
Labels
size/S
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@SuperJMN @danwalmsley @jmacato @MaxHillebrand @yahiheb