Improve CoinJoinClient by extracting OutputRegistration Phase related progress #7533
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Mar 12, 2022
|
Tested with 10 wallets, seems to be working OK. I know this specific PR is not a big change but I am also testing the new time distribution of requests. https://mempool.space/testnet/tx/2fcb11a7554a4280decfe23f7fb540327dace1e444063b26f4c738644ecf818e |
|
CoinJoinClient.cs improves its Code Health from 8.36 -> 8.83 |
|
Code LGTM |
MaxHillebrand
previously approved these changes
Mar 14, 2022
adamPetho
previously approved these changes
Mar 14, 2022
lontivero
requested changes
Mar 14, 2022
| var outputRegistrationEndTime = DateTimeOffset.UtcNow + (remainingTime * 0.8); | ||
| var readyToSignEndTime = outputRegistrationEndTime + remainingTime * 0.2; | ||
|
|
||
| using CancellationTokenSource outputRegPhaseTimeoutCts = new(remainingTime + TimeSpan.FromMinutes(1)); |
There was a problem hiding this comment.
Where does the magic 1min comes from?
There was a problem hiding this comment.
Extra margin, the value coming from common sense - synchronization delays with the coordinator. Maybe it is too much, but we are on the right side of the horse because under no circumstances should the client cancels the operations accidentally before it was canceled by the backend.
|
Lucas ACK-ed on a meeting. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
based on #7529
I've also added a phase-specific timeout cancellationToken.