Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Switch JsonConverters from 'JsonConverter' to 'JsonConverter<T>' #7666

Merged
merged 1 commit into from
Apr 4, 2022
Merged

Switch JsonConverters from 'JsonConverter' to 'JsonConverter<T>' #7666

merged 1 commit into from
Apr 4, 2022

Conversation

yahiheb
Copy link
Collaborator

@yahiheb yahiheb commented Mar 30, 2022

Recreated #7587 but without RoundStateResponseJsonConverter.cs which caused an issue that lead to #7665.

@kiminuo
Copy link
Contributor

kiminuo commented Mar 30, 2022

@yahiheb It would be great to start CJing with this branch over night so that we get some reasonable confidence there is no other issue.

MaxHillebrand
MaxHillebrand approved these changes Mar 31, 2022
View reviewed changes
Copy link
Contributor

@MaxHillebrand MaxHillebrand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tACK 5a5ea1c

@yahiheb
Copy link
Collaborator Author

yahiheb commented Mar 31, 2022

@yahiheb It would be great to start CJing with this branch over night so that we get some reasonable confidence there is no other issue.

I was able to do a couple of coinjoins with this PR, so it looks good.

kiminuo
kiminuo approved these changes Mar 31, 2022
View reviewed changes
Copy link
Contributor

@kiminuo kiminuo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

molnard
molnard approved these changes Apr 4, 2022
View reviewed changes
Copy link
Contributor

@molnard molnard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tACK

@molnard molnard merged commit 9ce13c6 into WalletWasabi:master Apr 4, 2022
@molnard
Copy link
Contributor

molnard commented Apr 4, 2022

🚀

@yahiheb yahiheb deleted the jsonconverters branch April 4, 2022 16:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@molnard molnard molnard approved these changes

@MaxHillebrand MaxHillebrand MaxHillebrand approved these changes

@kiminuo kiminuo kiminuo approved these changes

@lontivero lontivero Awaiting requested review from lontivero

Assignees
No one assigned
Labels
size/L
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@yahiheb @kiminuo @molnard @MaxHillebrand