Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[VDG] Send View - BTC and Fiat currency inputs #7690

Merged
merged 8 commits into from Apr 6, 2022

Conversation

ichthus1604
Copy link
Collaborator

  • Enables typing on both the BTC and the fiat inputs in the send screen
  • User preference is persisted in UI config

image

@ichthus1604 ichthus1604 changed the title Send View - BTC and Fiat currency inputs [VDG] Send View - BTC and Fiat currency inputs Apr 4, 2022
@yahiheb
Copy link
Collaborator

yahiheb commented Apr 4, 2022

This looks very promising.

@MaxHillebrand
Copy link
Member

Yes, this is great, it addresses #5165

Copy link
Member

@MaxHillebrand MaxHillebrand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tested 12e26bd

sometimes, clicking the switch button does not switch it, not sure exactly why, but I can sometimes reproduce.

also, when it switches, it highlights/selects the left amount, probably better to just put the courser there.

Dan mentioned to make it look like a single textbox, but I think I would prefer how it currently is with two distinct text boxes.

Also add the wave icon "is roughly" always before the fiat option.

@ichthus1604
Copy link
Collaborator Author

ichthus1604 commented Apr 4, 2022

Latest commit includes visual improvements, and the control's readonly state template, which wasn't properly designed before

@MaxHillebrand can't reproduce the button issue. clicking swaps every time for me.

also, when it switches, it highlights/selects the left amount, probably better to just put the courser there

This is the default behavior of the currency entry, also I think it's good ux, because if you're swapping that means you probably want to enter the exact right side amount specifically

Also add the wave icon "is roughly" always before the fiat option.

Should be there already?

@ichthus1604
Copy link
Collaborator Author

@MaxHillebrand latest commit adds ~ symbol to the fiat watermark, maybe that's what you were seeing?

MaxHillebrand
MaxHillebrand previously approved these changes Apr 4, 2022
Copy link
Member

@MaxHillebrand MaxHillebrand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tACK 585c078

looks great now - cannot reproduce that earlier described bug.

2022-04-04-182144

# Conflicts:
#	WalletWasabi.Fluent/Controls/CurrencyEntryBox.axaml.cs
Copy link
Collaborator

@yahiheb yahiheb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

WalletWasabi.Fluent/Controls/CurrencyEntryBox.axaml Outdated Show resolved Hide resolved
soosr
soosr previously approved these changes Apr 5, 2022
Copy link
Collaborator

@soosr soosr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Collaborator

@soosr soosr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tACK

@soosr soosr requested a review from danwalmsley April 5, 2022 15:47
Copy link
Member

@MaxHillebrand MaxHillebrand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tACK eed9091

Looks pretty and it's a wonderful solution that combines both possible UX approaches.

Very well done!

@SuperJMN SuperJMN self-requested a review April 6, 2022 12:43
Copy link
Collaborator

@SuperJMN SuperJMN left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tACK.
I took special attention to the code. I've not seen any noticeable problem in it. It's quite clear and readable.

Good work @ichthus1604!

@danwalmsley danwalmsley merged commit fca493a into zkSNACKs:master Apr 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants