Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[VDG] Fix wrong dialog behavior #7811

Merged
merged 3 commits into from Apr 20, 2022

Conversation

SuperJMN
Copy link
Collaborator

This is a regression introduced with the new "Store" style.

When a dialog is visible, the user can still interact with the items behind. This fixes that by disabling the behind content when a dialog is shown.

This fixes #7763

When a dialog is visible, the user can still interact with the items behind. This fixes that by disabling the behind content when a dialog is shown.
Copy link
Collaborator

@soosr soosr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The window cannot be dragged by the titlebar in the area of the searchbar.
I wonder if binding IsHitTestVisible of the searchbar to IsMainContentEnabled solves it?

image

@SuperJMN
Copy link
Collaborator Author

SuperJMN commented Apr 20, 2022

The window cannot be dragged by the titlebar in the area of the searchbar. I wonder if binding IsHitTestVisible of the searchbar to IsMainContentEnabled solves it?

That's right! worked like a charm :D

Co-authored-by: Roland Soós <soos.roland93@gmail.com>
@SuperJMN SuperJMN requested a review from soosr April 20, 2022 12:29
Copy link
Collaborator

@soosr soosr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@soosr soosr merged commit f865b4b into zkSNACKs:master Apr 20, 2022
@SuperJMN SuperJMN deleted the issues/regression-fix-dialog-behavior branch April 24, 2022 19:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Disable search bar when another dialog is displayed?
2 participants