New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Recovery wallet auto complete #810
Recovery wallet auto complete #810
Conversation
42aa826
to
5dc35a2
Compare
@danwalmsley could you give me a hand, please? This code works okay but there are a couple of thing it would be good if you could review them:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would just like you to consider if the Autocomplete box control is more suitable, if so it might allow better viewmodel code.
@@ -50,11 +52,10 @@ private void HandleAutoUpdate() | |||
var text = textBox.Text; | |||
var enteredWordList = text.Split(' ', StringSplitOptions.RemoveEmptyEntries); | |||
var lastWorld = enteredWordList.LastOrDefault(); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
typo lastWord :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yes, you're right. I cannot listen the national inflation forecast report and program at the same time.
using System.Linq; | ||
using System.Reactive.Disposables; | ||
using System.Reactive.Linq; | ||
using WalletWasabi.Gui.Tabs.WalletManager; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Iv never used it but Avalonia has an inbuilt auto completing textbox control, this might perhaps be more suitable?
https://github.com/AvaloniaUI/Avalonia/blob/master/src/Avalonia.Controls/AutoCompleteBox.cs
It is also in the control catalog if you want to evaluate the way it works.
…es/Recovery-Wallet-AutoComplete
…omplete Fix caret positioning
Update This can be merged now. Thanks @danwalmsley |
This PR is for improving the recovery wallet mnemonic suggestions, making the suggested words clickable.