Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[VDG] Hide title text on minimum width #8122

Merged
merged 6 commits into from
May 24, 2022

Conversation

jmacato
Copy link
Contributor

@jmacato jmacato commented May 24, 2022

Screen.Recording.2022-05-24.at.5.50.54.PM.mp4

cc @zkSNACKs/visual-design-group

@soosr
Copy link
Contributor

soosr commented May 24, 2022

@wieslawsoltes Implemented stock behaviors for triggering things. https://github.com/wieslawsoltes/AvaloniaBehaviors/blob/master/samples/BehaviorsTestApplication.Base/Views/Pages/AddRemoveClassActionView.axaml#L28-L40

Can you take a look? Maybe you can use them

MaxHillebrand
MaxHillebrand previously approved these changes May 24, 2022
Copy link
Contributor

@MaxHillebrand MaxHillebrand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sexy

@jmacato
Copy link
Contributor Author

jmacato commented May 24, 2022

@soosr I encountered some problems with bindings inside a datatemplate with those behaviors. @wieslawsoltes is gonna take a look to see what i missed

…ehavior is not needed for windows / linux systems due to having more space and not having the window chrome buttons in the left.
@pull-request-size pull-request-size bot added size/S and removed size/M labels May 24, 2022
Copy link
Contributor

@soosr soosr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@soosr soosr merged commit 33ae434 into WalletWasabi:master May 24, 2022
@jmacato jmacato deleted the vdg/hide-title-on-minwidth branch May 24, 2022 12:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants