-
Notifications
You must be signed in to change notification settings - Fork 498
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[VDG] Fix bad flyout behavior after theme switch #8343
[VDG] Fix bad flyout behavior after theme switch #8343
Conversation
The flyout was in the wrong position.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
tACK
This fixes #8321
I am not really happy with these focus losses, and I think @yahiheb was right here #7897 (comment) in the sense it is not the best solution. SearchBar now breaks the usability for only keyboard users... When you keep pressing tabs and the focus reached the SearchBar, the next tabulator press breaks the focus and the user has to click somewhere in the software to give back the focus in order to continue using it with only the keyboard. Anyway using the software with a keyboard has never been perfect... but this is something that we should consider for the future. |
Me neither, but I think it's still acceptable. (At least while we rewrite the SearchBarBehavior) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
tACK, it's a fix afterall, later it can be improved.
Theme switching from the SearchBar makes the flyout appear in the wrong position.
The problem is that the behavior is detached and reattached. This causes issues with visuals (as popup locating in the wrong place).
This PR is a quick fix for the bad behavior.
It could have been more elegant (reopen after reattaching of previously detached). Unfortunately, it seems it's more complex than it initially looked.
Anyways, the behavior after this PR is completely acceptable, in my opinion.
I wouldn't like to spend too much time on this, because I would like to fully rewrite the popup behavior logic.
Fixes #8321