Use PeriodicRunner for Tor Status Checker #8536
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
That is based on PeriodicRunner.
SuperJMN
commented
Jun 26, 2022
SuperJMN
commented
Jun 26, 2022
kiminuo
reviewed
Jun 27, 2022
WalletWasabi.Tests/UnitTests/Tor/NetworkChecker/XmlIssueListParserTests.cs
Outdated
Show resolved
Hide resolved
kiminuo
reviewed
Jun 27, 2022
kiminuo
reviewed
Jun 27, 2022
WalletWasabi.Fluent/ViewModels/StatusIcon/StatusIconDesignViewModel.cs
Outdated
Show resolved
Hide resolved
…/github.com/SuperJMN/WalletWasabi into improvements/torchecker-use-periodic-runner
kiminuo
reviewed
Jun 27, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We want to replace the current checker that relies in
System.Reactivewith our ownPeriodicRunner.This will fix some issues, like Tor network being used before it's available.
Co-authored with @kiminuo.
TorNetworkCheckeris almost entirely by him.Thanks for your reference code and ideas.
Related to: