New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
HttpMessageHelper
: Change exception being thrown
#8810
HttpMessageHelper
: Change exception being thrown
#8810
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
utACK, code LGTM
1- When I do the following:
I get: Click to expand and to see the logs!
2- I get this error when I do the following:
Click to expand and to see the logs!
|
{ | ||
TorDoesntWorkSince = DateTimeOffset.UtcNow; | ||
} | ||
TorDoesntWorkSince ??= DateTimeOffset.UtcNow; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
note: fixes an analyzer error
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Related to #6215
This PR changes the exception being thrown in
HttpMessageHelper
fromNotSupportedException
(denoting unexpected failure) toTorConnectionReadException
(denoting failure that is expected to happen from time to time).The reason for this change is this (combined) log:
Basically, some Tor circuit
249
was closed due to some network issue (was the relay terminated? or disconnected somehow? IDK) and as such we did not get all data back.Expected behavior is that
TorHttpPool
will catch the newTorConnectionReadException
exception and repeat the request again.Resources
cc @yahiheb (because he seemed to experience #6215 the most)