Update Client Knots to 23.0

[yahiheb]

Closes #8202

Release notes: https://github.com/bitcoinknots/bitcoin/blob/v23.0.knots20220529-release-notes/doc/release-notes.md

Source of the binaries: https://bitcoinknots.org/files/23.x/23.0.knots20220529/

I got the binaries from the following folders:

bitcoin-23.0.knots20220529-win64.zip
bitcoin-23.0.knots20220529-x86_64-apple-darwin.tar.gz
bitcoin-23.0.knots20220529-x86_64-linux-gnu.tar.gz

[MaxHillebrand]

Hash sums match, thanks!

[kiminuo]

utACK. The change looks good to me.

[molnard]

Why upgrade?

[yahiheb]

#8202

To address #8202 and to use the latest release.

[molnard]

We are already using the latest (stable) version. I suggest only upgrading this if we have a good reason to do so - it works flawlessly. With the upgrade, we can lose stability and dev time. What are the benefits of upgrading?

[Kukks]

in WalletWasabi.Backend/docker-compose.yml, change image: btcpayserver/bitcoinknots:21.2 to image: btcpayserver/bitcoinknots:23.0

[yahiheb]

What are the benefits of upgrading?

@molnard Tbh I don't have an answer to that.

in WalletWasabi.Backend/docker-compose.yml, change image: btcpayserver/bitcoinknots:21.2 to image: btcpayserver/bitcoinknots:23.0

@Kukks Done.

[stale]

This has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

[kristapsk]

Backend now runs v23, it makes sense to reopen this and upgrade client too.

[molnard]

Backend now runs v23, it makes sense to reopen this and upgrade client too.

ACK, we have time to dogfood this now.

[molnard]

@yahiheb can you recreate the PR - I cannot reopen it: "branch was deleted".

[yahiheb]

@molnard I updated and reopened this PR if we wanna update Knots to 23.0

[molnard]

tACK.

I saw two warnings in the logs. Neither seems to be a problem now.

• Config options rpcuser and rpcpassword will soon be deprecated. Locally-run instances may remove rpcuser to use cookie-based auth, or may be replaced with rpcauth. Please see share/rpcauth for rpcauth auth generation.
• banlist.dat ignored because it can only be read by Bitcoin Knots version 22.x. Remove "C:\Bitcoin\banlist.dat" to silence this warning.

[kristapsk]

• Config options rpcuser and rpcpassword will soon be deprecated. Locally-run instances may remove rpcuser to use cookie-based auth, or may be replaced with rpcauth. Please see share/rpcauth for rpcauth auth generation.

Soon is already going on for years, so don't think it will be removed very soon, but in any case there is no benefits in not changing this. bitcoin/bitcoin#29240

Note that we already use cookie auth on servers, so it's well tested, supported by NBItcoin / Wasabi and safe to change.

[molnard]

cookie auth on servers, so it's well tested, supported by NBItcoin / Wasabi and safe to change

How complicated is that? Can you implement it @kristapsk ?

[kristapsk]

cookie auth on servers, so it's well tested, supported by NBItcoin / Wasabi and safe to change

How complicated is that? Can you implement it @kristapsk ?

Will look at it!

[lontivero]

There is nothing to do there. NBitcoin already supports it and works well. Just change connectionstring and that's all.

[kristapsk]

There is nothing to do there. NBitcoin already supports it and works well. Just change connectionstring and that's all.

Knots configuration needs to be changed for cookie auth, Wasabi connection string needs to be changed and probably should rewrite https://github.com/bitcoin/bitcoin/blob/master/share/rpcauth/rpcauth.py in C#.