TorTcpConnectionFactory: Add missing cancellation token
#8911
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lontivero
approved these changes
Aug 9, 2022
|
Why is it in draft? I think it is good. |
Mostly because I haven't had a chance to test it somehow. But then I'm not sure where we use HTTPS at the moment. I believe we don't with Wasabi Backend. So maybe for getting fees. Code-wise I believe it should be OK. One concern is that I'm not sure what exception is being thrown when the cancellation token is hit (hopefully |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This shows how the overloads work: https://github.com/dotnet/runtime/blob/0ec02c8c96e2eda06dc5b5edfdbdba0f36415082/src/libraries/System.Net.Security/src/System/Net/Security/SslStream.cs#L381-L422
.NET documentation: https://docs.microsoft.com/en-us/dotnet/api/system.net.security.sslstream.authenticateasclientasync?view=net-6.0#system-net-security-sslstream-authenticateasclientasync(system-net-security-sslclientauthenticationoptions-system-threading-cancellationtoken) -- unfortunately, they don't say what exception is thrown when the cancellation token is hit.