Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UpgradeTorBinaries: Add support for GEOIP upgrade #9072

Conversation

kiminuo
Copy link
Collaborator

@kiminuo kiminuo commented Sep 8, 2022

Fixes #9000

Testing

cd WalletWasabi/Microservices/Binaries

# To upgrade to the latest released Tor Browser version
.\UpgradeTorBinaries.ps1 -version "11.5.2"

# To test only geoip files upgrading
.\UpgradeTorBinaries.ps1 -version "11.5.2" -skipDownloading -skipExtractingBrowserArchives -skipExtractingTorBinaries -skipReplacingTorBinaries 

@kiminuo kiminuo requested a review from yahiheb September 8, 2022 20:05
@molnard
Copy link
Collaborator

molnard commented Sep 9, 2022

This is great. Make sure that the upgrade will happen before the next release. 🙏

@kiminuo kiminuo marked this pull request as ready for review September 9, 2022 16:41
molnard
molnard previously approved these changes Sep 9, 2022
Copy link
Collaborator

@molnard molnard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code LGTM @yahiheb pls test it and can be merged.

Copy link
Collaborator

@yahiheb yahiheb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Other than the few comments, tACK.

```powershell
cd WalletWasabi/Microservices/Binaries

# See what the latest released Tor Browser version is here: https://dist.torproject.org/torbrowser/.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Currently https://dist.torproject.org/torbrowser/ contains a 11.5.3 folder but it only contains binaries for android, so IMO we should use https://www.torproject.org/download/ to check the latest released Tor Browser version.

Suggested change
# See what the latest released Tor Browser version is here: https://dist.torproject.org/torbrowser/.
# See what the latest released Tor Browser version is here: https://www.torproject.org/download/

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I accepted the suggestion but I'm ~0 on this. That's because https://dist.torproject.org/torbrowser/ (btw: they delete old versions when they release new ones) shows all versions one can work with and https://www.torproject.org/download/ shows just the last one. In practice, this is not a big difference.

I mean it's still subjectively non-intuitive for people who don't know this stuff but imo it's as good as we can deliver at this time.

Co-authored-by: yahiheb <52379387+yahiheb@users.noreply.github.com>
Copy link
Collaborator

@yahiheb yahiheb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tACK

@yahiheb yahiheb merged commit 472386a into zkSNACKs:master Sep 11, 2022
@kiminuo kiminuo deleted the feature/2022-09-08-UpgradeTorBinaries-geoip-support branch September 11, 2022 15:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update the Tor binaries upgrade script to also upgrade the Geoip files
4 participants