New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
UpgradeTorBinaries
: Add support for GEOIP upgrade
#9072
UpgradeTorBinaries
: Add support for GEOIP upgrade
#9072
Conversation
This is great. Make sure that the upgrade will happen before the next release. 🙏 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code LGTM @yahiheb pls test it and can be merged.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Other than the few comments, tACK.
```powershell | ||
cd WalletWasabi/Microservices/Binaries | ||
|
||
# See what the latest released Tor Browser version is here: https://dist.torproject.org/torbrowser/. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Currently https://dist.torproject.org/torbrowser/ contains a 11.5.3
folder but it only contains binaries for android, so IMO we should use https://www.torproject.org/download/ to check the latest released Tor Browser version.
# See what the latest released Tor Browser version is here: https://dist.torproject.org/torbrowser/. | |
# See what the latest released Tor Browser version is here: https://www.torproject.org/download/ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I accepted the suggestion but I'm ~0 on this. That's because https://dist.torproject.org/torbrowser/ (btw: they delete old versions when they release new ones) shows all versions one can work with and https://www.torproject.org/download/ shows just the last one. In practice, this is not a big difference.
I mean it's still subjectively non-intuitive for people who don't know this stuff but imo it's as good as we can deliver at this time.
Co-authored-by: yahiheb <52379387+yahiheb@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
tACK
Fixes #9000
Testing