[VDG] Do not call SetWindowSize when windows state is Maximized

[wieslawsoltes]

Fixes: #8985
Fixes: #8986

[soosr]

I prefer this solution, just because it is simpler.

utACK.

[yahiheb]

This fixes #8986 (I am sure about login button is not fully visible)
But it does not fix #8985

[soosr]

But it does not fix #9185

You mean #8985?

[soosr]

tACK, it fixes both issues on windows.

One thing to mention... when my window opens at maximized. The top of the window is cut down a tiny bit. But this is not related to this PR I guess.

[soosr]

I have to test this on macOS as well because AFAIK the window doesn't know the screen until it is shown there. So the calculations in SetWindowSize would never happen.

[soosr]

I have to test this on macOS as well because AFAIK the window doesn't know the screen until it is shown there. So the calculations in SetWindowSize would never happen.

Tested, it works as expected.

[yahiheb]

But it does not fix #9185

You mean #8985?

Yes it does not fix that issue for me. WindowWidth & WindowHeight do not change when you maximize Wasabi window.

One thing to mention... when my window opens at maximized. The top of the window is cut down a tiny bit. But this is not related to this PR I guess.

Same here.

[soosr]

Yes it does not fix that issue for me. WindowWidth & WindowHeight do not change when you maximize Wasabi window.

It does not even have to change it in maximized state. Already discussed here #8985

[yahiheb]

I opened a new issue #9193 for #9185 (review)

tACK

[wieslawsoltes]

tACK, it fixes both issues on windows.

One thing to mention... when my window opens at maximized. The top of the window is cut down a tiny bit. But this is not related to this PR I guess.

This is different issue on Windows

[yahiheb]

tACK