Store MasterKey instead of Decrypt every time #9368
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lontivero
approved these changes
Oct 21, 2022
turbolay
approved these changes
Oct 21, 2022
There was a problem hiding this comment.
tACK
There is still something weird underlying, as sometimes it takes some time (even if it's always preloaded at login):
KeyManager.GetMasterExtKey (547) GetKey() returned in: 00:00:10.8310557
CoinJoinClient.SignTransactionAsync (483) sign will start, delta with scheduled date: 00:00:14.0477570
But this is outside of this PR's scope.
|
On mac I was still getting the same issue as well. So this might be an improvement but not solving my original issue. |
|
Are there any privacy concerns regarding this change? |
|
I don't see any. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improves #9339