Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[VDG] fix calculation of AreAllCoinsPrivate #9457

Merged
merged 1 commit into from Nov 8, 2022
Merged

[VDG] fix calculation of AreAllCoinsPrivate #9457

merged 1 commit into from Nov 8, 2022

Conversation

soosr
Copy link
Collaborator

@soosr soosr commented Nov 2, 2022

Fixes #9451

@soosr soosr requested a review from nopara73 November 2, 2022 12:57
@soosr
Copy link
Collaborator Author

soosr commented Nov 3, 2022

@zkSNACKs/visual-design-group need some review.

@soosr soosr requested a review from molnard November 5, 2022 14:33
molnard
molnard approved these changes Nov 7, 2022
View reviewed changes
Copy link
Collaborator

@molnard molnard left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, I cannot test it. If the trigger works okay, then it should work.

@soosr
Copy link
Collaborator Author

soosr commented Nov 7, 2022

LGTM, I cannot test it. If the trigger works okay, then it should work.

I tested it on RegTest. Will merge this if no new comment arrives until tomorrow.

yahiheb
yahiheb approved these changes Nov 8, 2022
View reviewed changes
Copy link
Collaborator

@yahiheb yahiheb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested, it fixes the mentioned issue.

@soosr soosr merged commit f619e14 into zkSNACKs:master Nov 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@molnard molnard molnard approved these changes

@yahiheb yahiheb yahiheb approved these changes

@nopara73 nopara73 Awaiting requested review from nopara73

Assignees
No one assigned
Labels
size/XS
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Bug] Music box doesn't disappear on changing profile
3 participants
@soosr @molnard @yahiheb