Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove default CTs from Tor code (2) #9487

Merged
merged 1 commit into from Nov 7, 2022
Merged

Remove default CTs from Tor code (2) #9487

merged 1 commit into from Nov 7, 2022

Conversation

kiminuo
Copy link
Collaborator

@kiminuo kiminuo commented Nov 6, 2022

Follow-up to #8979 (comment) so that it's hard to not propagate a cancellation token all the way down.

@kiminuo kiminuo marked this pull request as ready for review November 6, 2022 09:27
yahiheb
yahiheb approved these changes Nov 6, 2022
View reviewed changes
Copy link
Collaborator

@yahiheb yahiheb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kiminuo kiminuo requested a review from molnard November 7, 2022 13:02
molnard
molnard approved these changes Nov 7, 2022
View reviewed changes
Copy link
Collaborator

@molnard molnard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ack

@molnard molnard merged commit 5c3e5e5 into zkSNACKs:master Nov 7, 2022
@kiminuo kiminuo deleted the feature/2022-11-06-less-defaults branch November 8, 2022 10:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@molnard molnard molnard approved these changes

@yahiheb yahiheb yahiheb approved these changes

Assignees
No one assigned
Labels
size/M
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@kiminuo @molnard @yahiheb