Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use LogInfo in UpdateManager if it's called from Linux distro #9499

Merged
merged 3 commits into from Nov 11, 2022

Conversation

adamPetho
Copy link
Collaborator

@adamPetho adamPetho commented Nov 8, 2022

Fixes #9492

Don't do unnecessary work on Linux.

This PR logs only in Info level.

Szpoti
Szpoti previously approved these changes Nov 9, 2022
MarnixCroes
MarnixCroes previously approved these changes Nov 9, 2022
Copy link
Collaborator

@molnard molnard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Notification is not called at the end because of return.

@adamPetho adamPetho dismissed stale reviews from MarnixCroes and Szpoti via 384fca0 November 10, 2022 14:03
@adamPetho
Copy link
Collaborator Author

Notification is not called at the end because of return.

True. Done in 384fca0

@molnard molnard merged commit ab41088 into zkSNACKs:master Nov 11, 2022
@adamPetho adamPetho deleted the small_log_change branch November 11, 2022 10:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

UpdateManager: don't display exception message as error in logs on Linux
4 participants