Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Documentation] [Trivial] Update manual steps for RegTest setup #9554

Merged
merged 8 commits into from Nov 18, 2022
Merged

[Documentation] [Trivial] Update manual steps for RegTest setup #9554

merged 8 commits into from Nov 18, 2022

Conversation

SuperJMN
Copy link
Collaborator

@SuperJMN SuperJMN commented Nov 16, 2022 •
edited

Updates the doc:

  • Reflect that bitcoin.conf won't exist after setup. It needs to be created first.
  • Can't start more than 1 instance of Wasabi Wallet.
  • Minor corrections.

@SuperJMN
Update manual steps
e464f0b 
**bitcoin.conf** won't exist and needs to be created. Modify the doc to make this explicit.
adamPetho
adamPetho previously approved these changes Nov 16, 2022
View reviewed changes
Copy link
Collaborator

@adamPetho adamPetho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@pull-request-size pull-request-size bot added size/M and removed size/S labels Nov 17, 2022
yahiheb
yahiheb previously approved these changes Nov 17, 2022
View reviewed changes
Copy link
Collaborator

@yahiheb yahiheb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

adamPetho
adamPetho previously approved these changes Nov 17, 2022
View reviewed changes
@yahiheb yahiheb dismissed stale reviews from adamPetho and themself via af4909a November 17, 2022 15:14
yahiheb
yahiheb previously approved these changes Nov 17, 2022
View reviewed changes
Copy link
Collaborator

@yahiheb yahiheb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@SuperJMN SuperJMN requested a review from soosr November 18, 2022 09:39
soosr
soosr approved these changes Nov 18, 2022
View reviewed changes
Copy link
Collaborator

@soosr soosr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK

@yahiheb yahiheb merged commit 873b993 into zkSNACKs:master Nov 18, 2022
@SuperJMN SuperJMN deleted the patch-1 branch November 20, 2022 00:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@soosr soosr soosr approved these changes

@yahiheb yahiheb yahiheb approved these changes

@adamPetho adamPetho Awaiting requested review from adamPetho

Assignees
No one assigned
Labels
size/M
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@SuperJMN @soosr @adamPetho @yahiheb