New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix feerate calculation #9558
Merged
Merged
Fix feerate calculation #9558
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- First, someone has to pay for the common overhead, otherwise all the math is wrong. - Second, the balance and effective feerate were not taking the shared overhead into account.
lontivero
force-pushed
the
fix-feerate-calc
branch
from
November 16, 2022 19:28
764c409
to
5fe58ff
Compare
kiminuo
reviewed
Nov 16, 2022
kiminuo
reviewed
Nov 16, 2022
WalletWasabi/WabiSabi/Models/MultipartyTransaction/ConstructionState.cs
Outdated
Show resolved
Hide resolved
Co-authored-by: Kimi <58662979+kiminuo@users.noreply.github.com>
molnard
requested changes
Nov 18, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
cACK, see my review here #9566
And one more, the coordinator and the blame script are the same. So we are paying that fee twice.
molnard
approved these changes
Nov 18, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ACK
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #9323 and removes fee rate tolerance workaround. This PR takes into account the shared overhead for estimated size and effective fee rate depending on whether the coordinator pays for it or not.
Update:
For that reason the guard condition
EffectiveFeeRate < Parameters.MiningFeeRate
started to fail when the mining fee rate went up and the number of inputs/outputs went down. In other words: it was working just by pure chance.