Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[VDG] Privacy Ring - fix glitch during resize #9590

Merged
merged 1 commit into from Nov 22, 2022
Merged

[VDG] Privacy Ring - fix glitch during resize #9590

merged 1 commit into from Nov 22, 2022

Conversation

soosr
Copy link
Collaborator

@soosr soosr commented Nov 21, 2022

It will immediately clear the ring as the window is resized. Throttle time shouldn't affect it.

ichthus1604
ichthus1604 approved these changes Nov 22, 2022
View reviewed changes
Copy link
Collaborator

@ichthus1604 ichthus1604 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tACK. Ring looks much better now when resizing the window.

molnard
molnard approved these changes Nov 22, 2022
View reviewed changes
Copy link
Collaborator

@molnard molnard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

trustACK

@molnard molnard merged commit 5cab8c8 into zkSNACKs:master Nov 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@molnard molnard molnard approved these changes

@ichthus1604 ichthus1604 ichthus1604 approved these changes

@nopara74 nopara74 nopara74 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@soosr @molnard @ichthus1604 @nopara74