Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Trivial][Refactoring] Use compound assignment #9869

Merged
merged 2 commits into from Jan 5, 2023
Merged

[Trivial][Refactoring] Use compound assignment #9869

merged 2 commits into from Jan 5, 2023

Conversation

yahiheb
Copy link
Collaborator

@yahiheb yahiheb commented Jan 1, 2023

No description provided.

@molnard
Copy link
Collaborator

molnard commented Jan 2, 2023

cACK

molnard
molnard approved these changes Jan 3, 2023
View reviewed changes
Copy link
Collaborator

@molnard molnard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🥇

@molnard
Copy link
Collaborator

molnard commented Jan 3, 2023

Resolve the conflict and can be merged.

@pull-request-size pull-request-size bot added size/S and removed size/M labels Jan 3, 2023
kiminuo
kiminuo approved these changes Jan 3, 2023
View reviewed changes
Copy link
Collaborator

@kiminuo kiminuo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

untested LGTM

Szpoti
Szpoti approved these changes Jan 4, 2023
View reviewed changes
Copy link
Collaborator

@Szpoti Szpoti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK

@kiminuo kiminuo merged commit 4e55d69 into zkSNACKs:master Jan 5, 2023
@yahiheb yahiheb deleted the compound-assignment branch January 5, 2023 07:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Szpoti Szpoti Szpoti approved these changes

@kiminuo kiminuo kiminuo approved these changes

@molnard molnard Awaiting requested review from molnard

Assignees
No one assigned
Labels
size/S
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@yahiheb @molnard @Szpoti @kiminuo