Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove Config.TryEnsureBackwardsCompatibility #9958

Merged
merged 2 commits into from Feb 9, 2023
Merged

Remove Config.TryEnsureBackwardsCompatibility #9958

merged 2 commits into from Feb 9, 2023

Conversation

kiminuo
Copy link
Collaborator

@kiminuo kiminuo commented Jan 17, 2023 •
edited

Depends on #8074.

See #8074 (comment)

@kiminuo kiminuo mentioned this pull request Jan 17, 2023
Merged
@kiminuo kiminuo marked this pull request as ready for review January 25, 2023 10:36
yahiheb
yahiheb approved these changes Jan 25, 2023
View reviewed changes
Copy link
Collaborator

@yahiheb yahiheb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK

@kiminuo kiminuo requested a review from molnard January 26, 2023 12:49
@kiminuo
Copy link
Collaborator Author

kiminuo commented Feb 1, 2023

@molnard Could you review this PR please?

@kiminuo kiminuo requested a review from turbolay February 3, 2023 09:03
molnard
molnard approved these changes Feb 8, 2023
View reviewed changes
Copy link
Collaborator

@molnard molnard left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, did someone test it?

@kiminuo
Copy link
Collaborator Author

kiminuo commented Feb 8, 2023

I tried to run WW several times and I did not notice anything weird.

molnard
molnard approved these changes Feb 9, 2023
View reviewed changes
Copy link
Collaborator

@molnard molnard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Gj

@molnard molnard merged commit 30a2d71 into zkSNACKs:master Feb 9, 2023
@kiminuo kiminuo deleted the feature/2023-01-17-remove-BC-code branch February 9, 2023 13:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@molnard molnard molnard approved these changes

@yahiheb yahiheb Awaiting requested review from yahiheb

@turbolay turbolay Awaiting requested review from turbolay

Assignees
No one assigned
Labels
size/L
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@kiminuo @molnard @yahiheb