Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ProcessAsync: Cleanup #9961

Merged
merged 2 commits into from Jan 19, 2023
Merged

ProcessAsync: Cleanup #9961

merged 2 commits into from Jan 19, 2023

Conversation

kiminuo
Copy link
Collaborator

@kiminuo kiminuo commented Jan 18, 2023 •
edited

Remove unused code. At this point, we need ProcessAsync only for mocking purposes. Originally, ProcessAsync was implemented because Process.WaitForExitAsync was not implemented in .NET.

Imho our encapsulation of Process should be as thin as possible.

@pull-request-size pull-request-size bot added size/M and removed size/S labels Jan 19, 2023
@kiminuo kiminuo marked this pull request as ready for review January 19, 2023 07:49
@lontivero lontivero merged commit 0466723 into zkSNACKs:master Jan 19, 2023
@kiminuo kiminuo deleted the feature/2023-01-18-unused-code branch January 19, 2023 14:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lontivero lontivero lontivero approved these changes

Assignees
No one assigned
Labels
size/M
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@kiminuo @lontivero