Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add shields image #522

Merged
merged 2 commits into from Jan 25, 2020
Merged

Add shields image #522

merged 2 commits into from Jan 25, 2020

Conversation

dennisreimann
Copy link
Contributor

As requested in #478.

@dennisreimann
Add shields image
5318891 
As requested in #478.
yahiheb
yahiheb approved these changes Jan 24, 2020
View reviewed changes
Copy link
Collaborator

@yahiheb yahiheb left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tACK. Very good.

MaxHillebrand
MaxHillebrand approved these changes Jan 25, 2020
View reviewed changes
Copy link
Member

@MaxHillebrand MaxHillebrand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested locally, looks quite nice, thanks!

But @dennisreimann, I thought rather about having a shield as icon within the line of test, so that we can replace the words red shield yellow shield green shield check-mark shield with icons directly in the line. I'm not sure if I explain it properly...

screenshot_20200125_095236

@RiccardoMasutti
Copy link
Contributor

@MaxHillebrand that would be awesome!

@yahiheb
Copy link
Collaborator

yahiheb commented Jan 25, 2020

But @dennisreimann, I thought rather about having a shield as icon within the line of test, so that we can replace the words red shield yellow shield green shield check-mark shield with icons directly in the line. I'm not sure if I explain it properly...

I say we merge this and do what Max suggested in another PR

@MaxHillebrand
Copy link
Member

@yahiheb, he's working on this right now, I'll merge the proper version directly in just one moment.

image

@dennisreimann
Copy link
Contributor Author

Updated as discussed with @MaxHillebrand. 🛡

MaxHillebrand
MaxHillebrand approved these changes Jan 25, 2020
View reviewed changes
Copy link
Member

@MaxHillebrand MaxHillebrand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh what marvelous sight this is to behold!!

screenshot_20200125_175722

This is exactly what I envisioned, thanks @dennisreimann !!!

I think this is ready for merge now, what do you say @yahiheb @RiccardoMasutti ?

yahiheb
yahiheb approved these changes Jan 25, 2020
View reviewed changes
Copy link
Collaborator

@yahiheb yahiheb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tACK

@lontivero lontivero merged commit 4de1051 into zkSNACKs:master Jan 25, 2020
@dennisreimann dennisreimann deleted the shields branch January 27, 2020 20:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lontivero lontivero lontivero approved these changes

@MaxHillebrand MaxHillebrand MaxHillebrand approved these changes

@yahiheb yahiheb yahiheb approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@dennisreimann @RiccardoMasutti @yahiheb @MaxHillebrand @lontivero