Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: removes hash from ZeekMessages contract on Atlas #1

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

xlmtvv
Copy link

@xlmtvv xlmtvv commented Jun 23, 2024

Description

I was working through the zkSync documentation and noticed a discrepancy between the ZeekMessages contract example in the docs and the version in this repository.

Changes

The documentation presents a version of the contract that stores messages directly as strings, while the current version in the repository hashes the messages before storing them.

To ensure consistency between the documentation and the codebase, I've updated the ZeekMessages contract in this PR to match the version presented in the documentation:

Modified messages storage from bytes32[] to string[] to store messages as plain text.
Removed the hashing step from the sendMessage function.
This change aligns the contract implementation with what users would expect based on the documentation.

I have tested this updated contract on the Atlas platform to confirm that it compiles and functions as expected.

Please let me know if you have any questions or require any further adjustments.

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant