Added Clone to Evaluator trait #18
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zkat
approved these changes
Apr 26, 2021
zkat
added a commit
that referenced
this pull request
Apr 26, 2021
This reverts commit db52b7c. Oops, this prevents making trait objects.
zkat
pushed a commit
that referenced
this pull request
Apr 27, 2021
Co-authored-by: doomy <2640792-_doomy@users.noreply.gitlab.com>
zkat
added a commit
that referenced
this pull request
Apr 27, 2021
This reverts commit db52b7c. Oops, this prevents making trait objects.
zkat
pushed a commit
that referenced
this pull request
May 2, 2021
Co-authored-by: doomy <2640792-_doomy@users.noreply.gitlab.com>
zkat
added a commit
that referenced
this pull request
May 2, 2021
This reverts commit db52b7c. Oops, this prevents making trait objects.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey! Not sure if this is correct, but if I am operating arbitrarily over some
Evaluator, I'd like to be able to copy it, especially when passing that trait from a builder.