Update to bevy 0.10 #72
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zkat
reviewed
Mar 3, 2023
| BigBrainSet::Thinkers | ||
| .in_base_set(CoreSet::First) | ||
| .after(BigBrainSet::Scorers), | ||
| BigBrainSet::Actions.in_base_set(CoreSet::PreUpdate), |
There was a problem hiding this comment.
I've been kinda wondering if PreUpdate is really the appropriate stage for this, to begin with...
There was a problem hiding this comment.
It's definitely a safe option, but I can't say if it's appropriate or not. Ideally users would just be able to specify which set it would be in, but I'm not sure if that's possible by default with sets.
|
Tested this PR in my application and it seems to work fine. Also updated it to use the tagged release. As for the First and PreUpdate, might be a good idea to ask some of the ECS experts about their opinion on what would and wouldn't be appropriate base sets for it |
zkat
approved these changes
Mar 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Nothing too crazy in this update, except if someone does something weird in First, PreUpdate or Last they might need to specify .after/.before with the corresponding BigBrainSet