Panic when span is on \n in v5.4.1

[Boshen]

Input text: "/\n"
Input span: 0..2

thread '<unnamed>' panicked at 'byte index 2 is out of bounds of /', /Users/boshenchen/.cargo/registry/src/github.com-1ecc6299db9ec823/miette-5.4.1/src/handlers/graphical.rs:624:21

miette/src/handlers/graphical.rs

Line 624 in 3e25fd5

let text = &line.text[..offset - line.offset];

cc @Benjamin-L

[Boshen]

The previous version was able to point to the newline.

  × Syntax Error
   ╭─[./target/main.ts:1:1]
 1 │ /
   · ─┬
   ·  ╰── Unexpected Token
   ╰────

[Boshen]

It also panics if the span is on EOF.

[zkat]

@Benjamin-L lol are we still being cursed by the same issue?

[zh217]

I also had this problem on 5.4.1 and 5.4.0. Version 5.3.0 is fine.

[Benjamin-L]

Oof, yeah I didn't realize that spans that contained the EOL were previously supported. I'll have a fix for this up in a bit. While working this out, I found a few edge cases that we'll want to make sure we have good behavior for:

Edge Cases

CRLFs

In v5.3.0, these end up rendering like this:

Source: source\r\ntext\r\n here
Span: (8, 6)

Error: oops::my::bad

  × oops!
   ╭─[bad_file.rs:1:1]
 1 │ source
 2 │ text
   · ───┬──
   ·    ╰── this bit here
 3 │   here
   ╰────
  help: try doing it better next time?

This seems... probably not desirable, and instead the rendered highlight should only extend one visual column past the end of line.

EOF

The output for this is bad on all versions:

Source: source\ntext
Span: (7, 5)

Error: oops::my::bad

  × oops!
   ╭─[bad_file.rs:1:1]
 1 │     source
 2 │ ╭─▶ text
   ╰────
  help: try doing it better next time?

Similar to the CRLF case, I think the rendered highlight should only extend one column past the end of line.

[Benjamin-L]

It also panics if the span is on EOF.

@Boshen I actually wasn't able to reproduce this. When I tested v5.4.1 with a span including the EOF, I get the same bad behavior as v5.3.0, but I don't get a panic. Is this what you're seeing as well?