Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix wrong severity of related errors #234

Merged
merged 1 commit into from
Feb 9, 2023
Merged

Conversation

dalance
Copy link
Contributor

@dalance dalance commented Feb 7, 2023

Currently, the severity of the parent error is shown as the severity of related errors.
This PR fix it.

Closes #232

Copy link
Owner

@zkat zkat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oooh thanks for this!

@zkat
Copy link
Owner

zkat commented Feb 7, 2023

looks like you just need some clippy fixes

@dalance dalance force-pushed the fix_wrong_severity branch 2 times, most recently from 88f3d37 to 45e2e04 Compare February 8, 2023 00:08
@dalance
Copy link
Contributor Author

dalance commented Feb 8, 2023

Some clippy issues can't pass both 1.56.0 and stable.

  • 1.56.0
error: there is no argument named `enum_name`
  --> miette-derive/src/url.rs:87:55
   |
87 |                         let item_path = format!("enum.{enum_name}.html#variant.{ident}");
   |
  • stable
error: variables can be used directly in the `format!` string
  --> miette-derive/src/url.rs:87:41
   |
87 |                         let item_path = format!("enum.{}.html#variant.{}", enum_name, ident);
   |                                         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
   |
   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#uninlined_format_args
   = note: `-D clippy::uninlined-format-args` implied by `-D warnings

@zkat
Copy link
Owner

zkat commented Feb 8, 2023

Ah that's annoying. Let me look into making it so clippy only runs on stable, I guess. No point in running it on both anyway.

@dalance
Copy link
Contributor Author

dalance commented Feb 8, 2023

If you want to use 1.56.0 as MSRV, clippy should do at 1.56.0 only because new features which cause error at stable's clippy can't be used.

@zkat
Copy link
Owner

zkat commented Feb 8, 2023

yeah, I guess you're right :)

@zkat
Copy link
Owner

zkat commented Feb 9, 2023

b658fc0 should fix this hopefully

@zkat
Copy link
Owner

zkat commented Feb 9, 2023

Looks like we're good now! Thanks again :)

@zkat zkat merged commit 3497508 into zkat:main Feb 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Related reports render with the severity of the parent report.
2 participants