-
-
Notifications
You must be signed in to change notification settings - Fork 103
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix wrong severity of related errors #234
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
oooh thanks for this!
looks like you just need some clippy fixes |
88f3d37
to
45e2e04
Compare
45e2e04
to
c976717
Compare
Some clippy issues can't pass both 1.56.0 and stable.
|
Ah that's annoying. Let me look into making it so clippy only runs on stable, I guess. No point in running it on both anyway. |
If you want to use 1.56.0 as MSRV, clippy should do at 1.56.0 only because new features which cause error at stable's clippy can't be used. |
yeah, I guess you're right :) |
b658fc0 should fix this hopefully |
Looks like we're good now! Thanks again :) |
Currently, the severity of the parent error is shown as the severity of related errors.
This PR fix it.
Closes #232